Skip to content

Fix TypeScript Date type generation for time.Time fields#20

Merged
satvik007 merged 2 commits intomainfrom
fix-date-type-generation
Sep 23, 2025
Merged

Fix TypeScript Date type generation for time.Time fields#20
satvik007 merged 2 commits intomainfrom
fix-date-type-generation

Conversation

@satvik007
Copy link
Collaborator

@satvik007 satvik007 commented Sep 23, 2025

  • Changed generated TypeScript type from 'date' to 'Date' (capital D)
  • Added test cases for recursive embedded structs with pointers and dates
  • TypeScript uses 'Date' as the correct type name, not lowercase 'date'

🤖 Generated with Claude Code

@satvik007 @claude
Fix TypeScript Date type generation for time.Time fields
5dc6c8c 
- Changed generated TypeScript type from 'date' to 'Date' (capital D)
- Added test cases for recursive embedded structs with pointers and dates
- TypeScript uses 'Date' as the correct type name, not lowercase 'date'

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist
Copy link

gemini-code-assist bot commented Sep 23, 2025

Summary of Changes

Hello @satvik007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical type generation issue where Go's time.Time fields were being incorrectly translated to 'date' in the generated TypeScript output. The change ensures that the correct 'Date' type is used, improving compatibility and type safety for frontend consumers. Additionally, new comprehensive test cases have been added to validate the correct handling of recursive and embedded struct patterns, particularly when they include date fields and pointers.

Highlights

  • TypeScript Date Type Fix: Corrected the generated TypeScript type for time.Time fields from the incorrect lowercase 'date' to the proper 'Date' (capital D), aligning with TypeScript's standard Date object.
  • Enhanced Test Coverage: Introduced new test cases to specifically cover scenarios involving recursive embedded structs with pointers and time.Time fields, ensuring the type generation logic handles complex structures correctly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 23, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly changes the generated TypeScript type for time.Time from date to Date. The added test cases are comprehensive and cover recursive structures with dates, which is a great addition. I've suggested a minor improvement to the new test function to enhance its structure and readability by using sub-tests.

@satvik007 satvik007 merged commit 056103b into main Sep 23, 2025
2 checks passed
@satvik007 satvik007 deleted the fix-date-type-generation branch September 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirkostya009 sirkostya009 sirkostya009 approved these changes

@hi-rai hi-rai Awaiting requested review from hi-rai

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@satvik007 @sirkostya009